Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove autobind example from init commands #1949

Merged
merged 1 commit into from
Feb 6, 2022

Conversation

zachsmith1
Copy link
Contributor

@zachsmith1 zachsmith1 commented Feb 6, 2022

When developers are running init for the first time to generate base configs and files, an example is included in the autobind section that points to - "{{.}}/graph/model. The problem with this is that developers likely won't already have external types in this directory so any subsequent generate commands will fail with the error make sure you're using an import path to a package that exists. I've commented this field out from the configTemplate so that developers following simple tutorials online aren't immediately blocked when running init followed by generate. Leaving this commented out would still show how a developer could reference external/already-defined types elsewhere.

Should fix errors users are seeing for this: #1765

I have:

  • Added tests covering the bug / feature (see testing)
    (Not really needed)
  • Updated any relevant documentation (see docs)
    (Not really needed)

@frederikhors
Copy link
Collaborator

@StevenACoffman I think this is URGENT!

@zachsmith1 THANKS!

@StevenACoffman StevenACoffman merged commit a054373 into 99designs:master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants