Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read gqlgen.yml from io.Reader. #2607

Merged
merged 5 commits into from
Apr 9, 2023
Merged

Conversation

smac89
Copy link
Contributor

@smac89 smac89 commented Apr 5, 2023

Adds ability to read gqlgen.yml from io.Reader.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

closes #2606

@smac89 smac89 changed the title Patch 1 Read gqlgen.yml from io.Reader. Apr 5, 2023
@StevenACoffman
Copy link
Collaborator

Hey, thanks for this contribution, but it looks like there's some linting and test failures.

remove extra space to fix lint checks
Need to return the config
@smac89
Copy link
Contributor Author

smac89 commented Apr 8, 2023

@StevenACoffman thanks. I think those are good to go now

@coveralls
Copy link

Coverage Status

Coverage: 78.563% (+1.9%) from 76.636% when pulling bee4160 on smac89:patch-1 into 50c2829 on 99designs:master.

@StevenACoffman StevenACoffman merged commit 7bc1f62 into 99designs:master Apr 9, 2023
@smac89 smac89 deleted the patch-1 branch April 11, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] reading gqlgen.yml from io.Reader
3 participants