Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uint32 unmarshal #2631

Merged
merged 1 commit into from
May 11, 2023
Merged

Fix uint32 unmarshal #2631

merged 1 commit into from
May 11, 2023

Conversation

mdvalv
Copy link
Contributor

@mdvalv mdvalv commented May 10, 2023

The string unmarshal for uint32 used ParseInt instead of ParseUint, which would parse the wrong range of valid numbers.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

Fix uint32 unmarshal
50e3671 
The string unmarshal for uint32 used ParseInt instead of ParseUint,
which would parse the wrong range of valid numbers.
@coveralls
Copy link

Coverage Status

Coverage: 78.783% (-0.02%) from 78.807% when pulling 50e3671 on mdvalv:master into e62a027 on 99designs:master.

@StevenACoffman StevenACoffman merged commit 82a110c into 99designs:master May 11, 2023
@StevenACoffman
Copy link
Collaborator

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdvalv @coveralls @StevenACoffman