Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ctx as unused when no arguments for FieldContextFunc #2999

Merged
merged 2 commits into from
Apr 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 42 additions & 42 deletions _examples/chat/generated.go

Large diffs are not rendered by default.

92 changes: 46 additions & 46 deletions _examples/config/generated.go

Large diffs are not rendered by default.

94 changes: 47 additions & 47 deletions _examples/dataloader/generated.go

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion _examples/embedding/subdir/entity.generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

78 changes: 39 additions & 39 deletions _examples/embedding/subdir/gendir/generated.go

Large diffs are not rendered by default.

66 changes: 33 additions & 33 deletions _examples/embedding/subdir/prelude.generated.go

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions _examples/embedding/subdir/root.generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

68 changes: 34 additions & 34 deletions _examples/enum/api/exec.go

Large diffs are not rendered by default.

86 changes: 43 additions & 43 deletions _examples/federation/accounts/graph/generated.go

Large diffs are not rendered by default.

86 changes: 43 additions & 43 deletions _examples/federation/products/graph/generated.go

Large diffs are not rendered by default.

98 changes: 49 additions & 49 deletions _examples/federation/reviews/graph/generated.go

Large diffs are not rendered by default.

78 changes: 39 additions & 39 deletions _examples/fileupload/generated.go

Large diffs are not rendered by default.

94 changes: 47 additions & 47 deletions _examples/scalars/generated.go

Large diffs are not rendered by default.

86 changes: 43 additions & 43 deletions _examples/selection/generated.go

Large diffs are not rendered by default.

124 changes: 62 additions & 62 deletions _examples/starwars/generated/exec.go

Large diffs are not rendered by default.

78 changes: 39 additions & 39 deletions _examples/todo/generated.go

Large diffs are not rendered by default.

78 changes: 39 additions & 39 deletions _examples/type-system-extension/generated.go

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions codegen/field.gotpl
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ func (ec *executionContext) _{{$object.Name}}_{{$field.Name}}(ctx context.Contex
res := &{{ $field.TypeReference.Elem.GO | ref }}{}
{{- else }}
res := {{ $field.TypeReference.GO | ref }}{}
{{- end }}
{{- end }}
fc.Result = res
return ec.{{ $field.TypeReference.MarshalFunc }}(ctx, field.Selections, res)
{{- else}}
Expand Down Expand Up @@ -72,7 +72,7 @@ func (ec *executionContext) _{{$object.Name}}_{{$field.Name}}(ctx context.Contex
{{- end }}
}

func (ec *executionContext) {{ $field.FieldContextFunc }}(ctx context.Context, field graphql.CollectedField) (fc *graphql.FieldContext, err error) {
func (ec *executionContext) {{ $field.FieldContextFunc }}({{ if not $field.Args }}_{{ else }}ctx{{ end }} context.Context, field graphql.CollectedField) (fc *graphql.FieldContext, err error) {
fc = &graphql.FieldContext{
Object: {{quote $field.Object.Name}},
Field: field,
Expand Down
2 changes: 1 addition & 1 deletion codegen/testserver/followschema/builtinscalar.generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions codegen/testserver/followschema/complexity.generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions codegen/testserver/followschema/defaults.generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions codegen/testserver/followschema/defer.generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions codegen/testserver/followschema/directive.generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions codegen/testserver/followschema/embedded.generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion codegen/testserver/followschema/fields_order.generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading