Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Support averaging affine transforms with float parameters #1682

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

dzenanz
Copy link
Contributor

@dzenanz dzenanz commented Feb 26, 2024

So far, this was only possible with double parameters.

So far, this was only possible with double parameters.
@dzenanz
Copy link
Contributor Author

dzenanz commented Feb 26, 2024

Review/merge? This builds locally, and does not introduce any new test failures.

@cookpa
Copy link
Member

cookpa commented Feb 26, 2024

Looks good to me, have you confirmed that AverageAffineTransform / AverageAffineTransformNoRigid work as before? These are critical to the template building scripts, and I don't know if they are covered by the automated tests.

@cookpa
Copy link
Member

cookpa commented Feb 26, 2024

I'm building now and will test today

@dzenanz
Copy link
Contributor Author

dzenanz commented Feb 26, 2024

The changes changes only add a new way to use the class, they do not change how class behaves.

Trying to use it with float affine matrices caused compile error. The new code path is untested for now. But it should be tested soon by unit tests in https://github.com/dzenanz/ANTsWasm. Of course, adding some tests for the float affine averaging within this repository would be good, but I have no plans to do that. Anyone is welcome to do so.

@cookpa
Copy link
Member

cookpa commented Feb 26, 2024

Thanks, merging

@cookpa cookpa merged commit fc0e56d into ANTsX:master Feb 26, 2024
1 check passed
@dzenanz dzenanz deleted the floatAverageAffine branch February 26, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants