Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build USB libs with GCC_ARM #1

Merged
merged 1 commit into from
Apr 16, 2013
Merged

Build USB libs with GCC_ARM #1

merged 1 commit into from
Apr 16, 2013

Conversation

pbrier
Copy link
Contributor

@pbrier pbrier commented Apr 6, 2013

build USB libs with GCC_ARM

@emilmont
Copy link
Contributor

Hi Peter,
thank you for your contribution. Sorry for the delay, we were setting up our "contribution agreement" process, as you may have noticed: you made the first "pull request"! :-)

Could you please accept the standard "Apache" contributor agreement at the following URL?
http://mbed.org/contributor_agreement

To accept the agreement, you must be logged in with your "pbrier" mbed user account.

Thanks for your cooperation,
Emilio

PS: I will accept your pull request "as is", but, in the future, we may refactor it using the defines in libraries/mbed/capi/toolchain.h

@pbrier
Copy link
Contributor Author

pbrier commented Apr 10, 2013

Hi Emilio,

How do know I'm the same pbrier that accepted the contributor agreement
on mbed.com ;-)

Indeed the toolchain.h is a better place for these defines. I can change
it and do another pull req. if you like.

On 4/10/2013 11:07 AM, Emilio Monti wrote:

Hi Peter,
thank you for your contribution. Sorry for the delay, we were setting
up our "contribution agreement" process, as you may have noticed, you
made the first "pull request"! :-)

Could you please accept the standard "Apache" contributor agreement at
the following URL?
http://mbed.org/contributor_agreement

To accept the agreement, you must be logged in with your "pbrier" mbed
user account.

Thanks for your cooperation,
Emilio

PS: I will accept your pull request "as is", but, in the future, we
may refactor it, using the defines in libraries/mbed/capi/toolchain.h
https://github.com/mbedmicro/mbed/blob/master/libraries/mbed/capi/toolchain.h


Reply to this email directly or view it on GitHub
#1 (comment).

@emilmont
Copy link
Contributor

Hi Peter,
for the moment we trust the "Peter Brier" that signed the contribution agreement on "mbed.org", but we are adding a "pull request" process for the "mbed.org" repositories.

I can change it and do another pull req. if you like.

Yes, I would prefer it.
Although, it is acceptable for us refactoring it in a second step.

Cheers,
Emilio

emilmont added a commit that referenced this pull request Apr 16, 2013
Build USB libs with GCC_ARM
@emilmont emilmont merged commit 0037711 into ARMmbed:master Apr 16, 2013
0xc0170 pushed a commit that referenced this pull request Jul 15, 2014
Fix erroneous boolean expression conversions
PrzemekWirkus added a commit that referenced this pull request Aug 15, 2014
0xc0170 pushed a commit that referenced this pull request Jan 29, 2015
0xc0170 pushed a commit that referenced this pull request Feb 3, 2015
Add support for EA LPC4088_DM
0xc0170 pushed a commit that referenced this pull request May 6, 2015
0xc0170 pushed a commit that referenced this pull request May 21, 2015
0xc0170 pushed a commit that referenced this pull request Jul 31, 2015
0xc0170 pushed a commit that referenced this pull request Oct 26, 2015
0xc0170 pushed a commit that referenced this pull request Jan 15, 2016
Changed SPI implementation: #1 To avoid clearing data from buffers, during splitted DMA transfer
RX/TX buffer clear is done only when transfer is started.
USART transmit is completed instead of DMA/LDMA transfer completed.
0xc0170 pushed a commit that referenced this pull request May 2, 2016
Update to latest mbed code
bridadan pushed a commit that referenced this pull request Jun 21, 2016
bridadan pushed a commit that referenced this pull request Jun 21, 2016
This reverts commit 4ae6b05, reversing
changes made to 1ee1150.
bridadan pushed a commit that referenced this pull request Jun 21, 2016
Revert "Merge pull request #1 from 0xc0170/dev_update_rtos"
bridadan added a commit that referenced this pull request Jun 21, 2016
sg- pushed a commit that referenced this pull request Aug 5, 2016
Differentiate ASM and CXX symbols
0xc0170 pushed a commit that referenced this pull request Aug 19, 2016
network-socket: Peer address update for Nanostack
@mmahadevan108 mmahadevan108 mentioned this pull request Oct 12, 2016
1 task
SeppoTakalo pushed a commit that referenced this pull request Nov 9, 2016
licence and copyrights updated
SeppoTakalo pushed a commit that referenced this pull request Nov 9, 2016
copyright and licence updates
adbridge pushed a commit that referenced this pull request Dec 19, 2019
Update CMSIS-pack info for STM32G-family
andrewc-arm pushed a commit to andrewc-arm/mbed-os that referenced this pull request Jan 3, 2020
Signed-off-by: PARKJIHOON <jh6186.park@samsung.com>
jh6186 added a commit to andrewc-arm/mbed-os that referenced this pull request Jan 6, 2020
Signed-off-by: PARKJIHOON <jh6186.park@samsung.com>
andrewc-arm pushed a commit to andrewc-arm/mbed-os that referenced this pull request Jan 7, 2020
Signed-off-by: PARKJIHOON <jh6186.park@samsung.com>
andrewc-arm pushed a commit to andrewc-arm/mbed-os that referenced this pull request Jan 8, 2020
Signed-off-by: PARKJIHOON <jh6186.park@samsung.com>
LMESTM pushed a commit to LMESTM/mbed that referenced this pull request Jan 8, 2020
mbed-cloud-client-example R1.3.0-GA
andrewc-arm pushed a commit to andrewc-arm/mbed-os that referenced this pull request Jan 13, 2020
Signed-off-by: PARKJIHOON <jh6186.park@samsung.com>
andrewc-arm pushed a commit to andrewc-arm/mbed-os that referenced this pull request Jan 14, 2020
Signed-off-by: PARKJIHOON <jh6186.park@samsung.com>
andrewc-arm pushed a commit to andrewc-arm/mbed-os that referenced this pull request Jan 16, 2020
Signed-off-by: PARKJIHOON <jh6186.park@samsung.com>
andrewc-arm pushed a commit to andrewc-arm/mbed-os that referenced this pull request Jan 21, 2020
Signed-off-by: PARKJIHOON <jh6186.park@samsung.com>
andrewc-arm pushed a commit to andrewc-arm/mbed-os that referenced this pull request Jan 22, 2020
Signed-off-by: PARKJIHOON <jh6186.park@samsung.com>
adbridge pushed a commit that referenced this pull request Feb 5, 2020
Signed-off-by: PARKJIHOON <jh6186.park@samsung.com>
RyoheiHagimoto referenced this pull request in RyoheiHagimoto/mbed-os Mar 31, 2020
Signed-off-by: PARKJIHOON <jh6186.park@samsung.com>
0xc0170 pushed a commit that referenced this pull request Apr 16, 2020
Removing namespace pollution & rf ctrls refactor
0xc0170 pushed a commit that referenced this pull request Sep 2, 2020
updating wlan parameter configuration under appropriate settings
0xc0170 pushed a commit that referenced this pull request Oct 16, 2020
@mbed-ci

This comment has been minimized.

@mbed-ci
Copy link

mbed-ci commented Feb 17, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 24 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci-build-tfm-standalone

@mbed-ci
Copy link

mbed-ci commented Feb 17, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 25 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci-build-tfm-standalone

@mbed-ci
Copy link

mbed-ci commented Feb 17, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 26 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci-build-tfm-standalone

Patater added a commit to Patater/mbed-os that referenced this pull request May 26, 2021
Many test stub functions are meant to return a value, but weren't. Clang
would generate a warning for each instance where we weren't returning
anything in a function that was meant to return a value.

    warning: non-void function does not return a value [-Wreturn-type]

For a specific example, my_radio::time_on_air() is supposed to return a
uint32_t, but wasn't returning anything. We'll return a zero instead of
relying on undefined behavior.

Without this, clang 11.0.1 was generating a virtual function
implementation with a `ud2` instruction to abort at run-time, causing
some execution of some unit tests to abort.

    Running main() from gmock_main.cc
    [==========] Running 10 tests from 1 test suite.
    [----------] Global test environment set-up.
    [----------] 10 tests from Test_LoRaPHYUS915
    [ RUN      ] Test_LoRaPHYUS915.constructor
    [       OK ] Test_LoRaPHYUS915.constructor (0 ms)
    [ RUN      ] Test_LoRaPHYUS915.restore_default_channels
    [       OK ] Test_LoRaPHYUS915.restore_default_channels (0 ms)
    [ RUN      ] Test_LoRaPHYUS915.rx_config
    [       OK ] Test_LoRaPHYUS915.rx_config (0 ms)
    [ RUN      ] Test_LoRaPHYUS915.tx_config
    Process 35669 stopped
    * thread ARMmbed#1, name = 'lorawan-loraphy-', stop reason = signal SIGILL: privileged instruction
        frame #0: 0x0000000000276f73 lorawan-loraphy-us915-unittest`my_radio::time_on_air(this=0x0000000800c2b048, modem=MODEM_LORA, pkt_len='\0') at Test_LoRaPHYUS915.cpp:90:5
       87       };
       88
       89       virtual uint32_t time_on_air(radio_modems_t modem, uint8_t pkt_len)
    -> 90       {
       91       };
       92
       93       virtual bool perform_carrier_sense(radio_modems_t modem,
    (lldb) disassemble --pc
    lorawan-loraphy-us915-unittest`my_radio::time_on_air:
    ->  0x276f73 <+67>: ud2
        0x276f75:       int3
        0x276f76:       int3
        0x276f77:       int3
    (lldb)
Patater added a commit to Patater/mbed-os that referenced this pull request May 26, 2021
Many test stub functions are meant to return a value, but weren't. Clang
would generate a warning for each instance where we weren't returning
anything in a function that was meant to return a value.

    warning: non-void function does not return a value [-Wreturn-type]

For a specific example, my_radio::time_on_air() is supposed to return a
uint32_t, but wasn't returning anything. We'll return a zero instead of
relying on undefined behavior.

Without this, clang 11.0.1 was generating a virtual function
implementation with a `ud2` instruction to abort at run-time, causing
some execution of some unit tests to abort.

    Running main() from gmock_main.cc
    [==========] Running 10 tests from 1 test suite.
    [----------] Global test environment set-up.
    [----------] 10 tests from Test_LoRaPHYUS915
    [ RUN      ] Test_LoRaPHYUS915.constructor
    [       OK ] Test_LoRaPHYUS915.constructor (0 ms)
    [ RUN      ] Test_LoRaPHYUS915.restore_default_channels
    [       OK ] Test_LoRaPHYUS915.restore_default_channels (0 ms)
    [ RUN      ] Test_LoRaPHYUS915.rx_config
    [       OK ] Test_LoRaPHYUS915.rx_config (0 ms)
    [ RUN      ] Test_LoRaPHYUS915.tx_config
    Process 35669 stopped
    * thread ARMmbed#1, name = 'lorawan-loraphy-', stop reason = signal SIGILL: privileged instruction
        frame #0: 0x0000000000276f73 lorawan-loraphy-us915-unittest`my_radio::time_on_air(this=0x0000000800c2b048, modem=MODEM_LORA, pkt_len='\0') at Test_LoRaPHYUS915.cpp:90:5
       87       };
       88
       89       virtual uint32_t time_on_air(radio_modems_t modem, uint8_t pkt_len)
    -> 90       {
       91       };
       92
       93       virtual bool perform_carrier_sense(radio_modems_t modem,
    (lldb) disassemble --pc
    lorawan-loraphy-us915-unittest`my_radio::time_on_air:
    ->  0x276f73 <+67>: ud2
        0x276f75:       int3
        0x276f76:       int3
        0x276f77:       int3
    (lldb)
Patater added a commit to Patater/mbed-os that referenced this pull request May 27, 2021
Many test stub functions are meant to return a value, but weren't. Clang
would generate a warning for each instance where we weren't returning
anything in a function that was meant to return a value.

    warning: non-void function does not return a value [-Wreturn-type]

For a specific example, my_radio::time_on_air() is supposed to return a
uint32_t, but wasn't returning anything. We'll return a zero instead of
relying on undefined behavior.

Without this, clang 11.0.1 was generating a virtual function
implementation with a `ud2` instruction to abort at run-time, causing
some execution of some unit tests to abort.

    Running main() from gmock_main.cc
    [==========] Running 10 tests from 1 test suite.
    [----------] Global test environment set-up.
    [----------] 10 tests from Test_LoRaPHYUS915
    [ RUN      ] Test_LoRaPHYUS915.constructor
    [       OK ] Test_LoRaPHYUS915.constructor (0 ms)
    [ RUN      ] Test_LoRaPHYUS915.restore_default_channels
    [       OK ] Test_LoRaPHYUS915.restore_default_channels (0 ms)
    [ RUN      ] Test_LoRaPHYUS915.rx_config
    [       OK ] Test_LoRaPHYUS915.rx_config (0 ms)
    [ RUN      ] Test_LoRaPHYUS915.tx_config
    Process 35669 stopped
    * thread ARMmbed#1, name = 'lorawan-loraphy-', stop reason = signal SIGILL: privileged instruction
        frame #0: 0x0000000000276f73 lorawan-loraphy-us915-unittest`my_radio::time_on_air(this=0x0000000800c2b048, modem=MODEM_LORA, pkt_len='\0') at Test_LoRaPHYUS915.cpp:90:5
       87       };
       88
       89       virtual uint32_t time_on_air(radio_modems_t modem, uint8_t pkt_len)
    -> 90       {
       91       };
       92
       93       virtual bool perform_carrier_sense(radio_modems_t modem,
    (lldb) disassemble --pc
    lorawan-loraphy-us915-unittest`my_radio::time_on_air:
    ->  0x276f73 <+67>: ud2
        0x276f75:       int3
        0x276f76:       int3
        0x276f77:       int3
    (lldb)
MubeenHCLite pushed a commit to MubeenHCLite/mbed-os that referenced this pull request Jun 14, 2021
Many test stub functions are meant to return a value, but weren't. Clang
would generate a warning for each instance where we weren't returning
anything in a function that was meant to return a value.

    warning: non-void function does not return a value [-Wreturn-type]

For a specific example, my_radio::time_on_air() is supposed to return a
uint32_t, but wasn't returning anything. We'll return a zero instead of
relying on undefined behavior.

Without this, clang 11.0.1 was generating a virtual function
implementation with a `ud2` instruction to abort at run-time, causing
some execution of some unit tests to abort.

    Running main() from gmock_main.cc
    [==========] Running 10 tests from 1 test suite.
    [----------] Global test environment set-up.
    [----------] 10 tests from Test_LoRaPHYUS915
    [ RUN      ] Test_LoRaPHYUS915.constructor
    [       OK ] Test_LoRaPHYUS915.constructor (0 ms)
    [ RUN      ] Test_LoRaPHYUS915.restore_default_channels
    [       OK ] Test_LoRaPHYUS915.restore_default_channels (0 ms)
    [ RUN      ] Test_LoRaPHYUS915.rx_config
    [       OK ] Test_LoRaPHYUS915.rx_config (0 ms)
    [ RUN      ] Test_LoRaPHYUS915.tx_config
    Process 35669 stopped
    * thread ARMmbed#1, name = 'lorawan-loraphy-', stop reason = signal SIGILL: privileged instruction
        frame #0: 0x0000000000276f73 lorawan-loraphy-us915-unittest`my_radio::time_on_air(this=0x0000000800c2b048, modem=MODEM_LORA, pkt_len='\0') at Test_LoRaPHYUS915.cpp:90:5
       87       };
       88
       89       virtual uint32_t time_on_air(radio_modems_t modem, uint8_t pkt_len)
    -> 90       {
       91       };
       92
       93       virtual bool perform_carrier_sense(radio_modems_t modem,
    (lldb) disassemble --pc
    lorawan-loraphy-us915-unittest`my_radio::time_on_air:
    ->  0x276f73 <+67>: ud2
        0x276f75:       int3
        0x276f76:       int3
        0x276f77:       int3
    (lldb)
danilomendonca added a commit to danilomendonca/mbed-os that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants