make the extension disable instead of unlisted. fix linter

modules/extensions.py

@@ -204,7 +204,7 @@ def list_extensions():
             }
 
     # check for requirements
-    for (canonical_name, extension_data) in extension_dependency_map.items():
+    for (_, extension_data) in extension_dependency_map.items():
         dirname, path, requires = extension_data['dirname'], extension_data['path'], extension_data['requires']
         requirement_met = True
         for req in requires:
@@ -220,9 +220,8 @@ def list_extensions():
                 requirement_met = False
                 break
 
-        if not requirement_met:
-            continue
-
         is_builtin = dirname == extensions_builtin_dir
-        extension = Extension(name=dirname, path=path, enabled=dirname not in shared.opts.disabled_extensions, is_builtin=is_builtin)
+        extension = Extension(name=dirname, path=path,
+                              enabled=dirname not in shared.opts.disabled_extensions and requirement_met,
+                              is_builtin=is_builtin)
         extensions.append(extension)

modules/scripts.py

@@ -434,8 +434,8 @@ def list_scripts(scriptdirname, extension, *, include_extensions=True):
     try:
         ordered_script = sorter.static_order()
     except CycleError:
-        errors.report(f"Cycle detected in script dependencies. Scripts will load in ascending order.", exc_info=True)
-        ordered_script = [x for x in script_dependency_map.keys()]
+        errors.report("Cycle detected in script dependencies. Scripts will load in ascending order.", exc_info=True)
+        ordered_script = script_dependency_map.keys()
 
     for script_filename in ordered_script:
         script_data = script_dependency_map[script_filename]