Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: call shared.state.end() after postprocessing done #13977

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

aria1th
Copy link
Collaborator

@aria1th aria1th commented Nov 15, 2023

Description

The shared.state.end() was missing in modules/postprocessing.py.

This will result the invalid API response as result after the job is done:

{'progress': 0.01,
 'eta_relative': 8755.73311328888,
 'state': {'skipped': False,
  'interrupted': False,
  'job': 'CodeFormer',
  'job_count': -1,
  'job_timestamp': '20231115141010',
  'job_no': 0,
  'sampling_step': 0,
  'sampling_steps': 20},
 'current_image': None,
 'textinfo': None}

The related test should be added to check API status.

Screenshots/videos:

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit b945ba7 into dev Nov 19, 2023
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the hotfix-postprocessing-state-end branch November 19, 2023 05:59
@w-e-w w-e-w mentioned this pull request Dec 4, 2023
@w-e-w w-e-w mentioned this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants