fix extra-network-control--enabled color #14900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add forgotten semicolon
AUTOMATIC1111
approved these changes
Feb 17, 2024
AUTOMATIC1111
deleted the
fix-css-color-extra-network-control--enabled
branch
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the color for
extra-network-control--enabledcss is broken,there's duplicate rules for dark mode but none for light mode
I also change it to use transparency so that it looks better
Note
Personally I'm not too keen on highlighting icon whn enabled, I think it's unnecessary
hover highlighting might be a thing
this PR is more about fix the broken CSS so I did not remove it
Screenshots/videos:
other minor changes
Checklist: