fix modalImageViewer preview/result flicker #16426
Open
+18
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when
opts.js_live_preview_in_modal_lightboxis disable the full page image viewer should show the result image and not live previewbut there is an issue that even when
js_live_preview_in_modal_lightboxis disabled, if live preview image is available it will show the live preview image briefly before it displays the result imagethis PR fixed the flicker issue
Screenshots/videos:
before PR (current)
2024-08-26.10_51_15_520.chrome.mp4
with PR (fix)
2024-08-26.10_53_12_272.chrome.mp4
Checklist: