Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix combine2 implementation in MDL #1975

Conversation

krohmerNV
Copy link
Contributor

Fix a regression after this commit.

Add a custom implementation for combine2(color, float) because the index access is not allowed on the MDL color type.

…dex access is not allowed on the MDL color type
@krohmerNV krohmerNV changed the title MDL: fix combin2(color, float) MDL: fix combine2(color, float) Aug 16, 2024
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
@jstone-lucasfilm jstone-lucasfilm changed the title MDL: fix combine2(color, float) Fix combine2 implementation in MDL Aug 17, 2024
Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix, @krohmerNV, and this looks worthwhile to include in 1.39.1.

@jstone-lucasfilm jstone-lucasfilm merged commit 153a803 into AcademySoftwareFoundation:main Aug 17, 2024
34 checks passed
@krohmerNV
Copy link
Contributor Author

Thanks for the fixes @jstone-lucasfilm
And yes, it would be nice to be included in the next release, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants