Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add utility to "normalize" numeric string values on a Document #1988

Closed
wants to merge 9 commits into from
Closed

Add utility to "normalize" numeric string values on a Document #1988

wants to merge 9 commits into from

Commits on Aug 23, 2024

  1. - Add in number string normalization. normalizeNumericString() 

    - Use in Document new value normalization interface:  Document.normalizeValueStrings()
- Add in unit tests for each.
    @kwokcb
    kwokcb committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    d06546b View commit details
    Browse the repository at this point in the history

  2. Remove extra newline

    @jstone-lucasfilm
    jstone-lucasfilm committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    5cc56c2 View commit details
    Browse the repository at this point in the history

  3. Code style updates

    @jstone-lucasfilm
    jstone-lucasfilm committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    0f31beb View commit details
    Browse the repository at this point in the history

  4. - Review changes: 

      - Simplify logic.
  - Remove precision clamping.
- Add JS wrapper.
    @kwokcb
    kwokcb committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8a237a3 View commit details
    Browse the repository at this point in the history

  5. Formatting fixes.

    @kwokcb
    kwokcb committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    512e757 View commit details
    Browse the repository at this point in the history

  6. Review updates. 

    - Add integer, matrix support
- Move type into more generic method.
- Update tests.
    @kwokcb
    kwokcb committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b706c10 View commit details
    Browse the repository at this point in the history

  7. Cleanup tests.

    @kwokcb
    kwokcb committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    57752b9 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Review Updates 

    - Do not remove trailing 0s for scientific notation. This just checks for the 'e' character after stripping leading and trailing spaces and leading zeros.
- Skip empty tokens, though this is invalid for MaterialX.
    @kwokcb
    kwokcb committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    43ea222 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Merge branch 'AcademySoftwareFoundation:main' into equivalence

    @kwokcb
    kwokcb committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    1b1fa70 View commit details
    Browse the repository at this point in the history