-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Element Equivalence Interfaces #2003
Open
kwokcb
wants to merge
7
commits into
AcademySoftwareFoundation:main
Choose a base branch
from
kwokcb:value_equivalent
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwokcb
commented
Sep 4, 2024
ld-kerley
reviewed
Sep 4, 2024
- Separate out results into option results class argument. - Add isAttributeEquivalent() to avoid duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Addresses issues: #1988 and #1981 dealing with comparison of element values by adding in a new "functionally" equivalent interface, such that functional equivalence means that the 2 elements perform the same computation. This differs from the existing
operator==
interface which checks for syntactical equivalence.The key points for functional equivalence include:
Element
does not matter.Document
or aCompound NodeGraph
.uimax
oruimin
).Name
andCategory
equivalence cannot be skipped.Changes
isEquivalent
method toElement
.isAttributeEquivalent
method forElement
and override forValueElement
to allow for value vs string comparisons on the latter.ElementEquivalanceOptions
which can be passed in as an argument toisEquivalent
ElementEquivalenceResult
which can be passed in as an argument toisEquivalent
andisAttributeEquivalent
.The following equivalence options are available:
ValueElement
. This is the same precision mechanism used for all value<->string conversions including values for code generation and file I/O.{ xpos, ypos }
.operator==
) currently does instead of value comparisons for aValueElement
.Implementation Notes
extraneous string formatting such as leading and trailing spaces,
0
and leading+
sign.Value
's string representation is used to perform the actual comparison allow for support of precision options.Tests
A new unit test has been added with various numeric variations to test values, ordering, and precision.
The document pair used for testing looks like this:
and