Skip to content

Commit

Permalink
Fixed comparing empty strings with nulls and undefined (#77)
Browse files Browse the repository at this point in the history
If you pulled a template without the text part and immediately run the push command, the program would show a change to that template. It was happening because we were comparing undefined to empty strings when detecting the changes.

* Fixed comparing empty strings with nulls and undefined
* Split tests into unit and integration
  • Loading branch information
tomek-ac committed Aug 16, 2023
1 parent c92c593 commit f926c7d
Show file tree
Hide file tree
Showing 8 changed files with 261 additions and 303 deletions.
9 changes: 9 additions & 0 deletions .mocharc.integration.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"diff": true,
"extension": ["test.ts"],
"require": "ts-node/register",
"spec": "test/integration",
"recursive": true,
"retries": 1,
"timeout": 10000
}
7 changes: 7 additions & 0 deletions .mocharc.unit.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"diff": true,
"extension": ["test.ts"],
"require": "ts-node/register",
"spec": "test/unit",
"recursive": true
}
Loading

0 comments on commit f926c7d

Please sign in to comment.