Improve test coverage

Ref. #334

Makefile

@@ -64,7 +64,7 @@ test_python_optimized:
 	python3 -O -m pytest -n$(shell nproc) -vv -m "not hypothesis"
 
 test_python_coverage:
-	python3 -m pytest -n$(shell nproc) -vv --cov=rflx --cov-branch --cov-fail-under=98.6 --cov-report=term-missing -m "not hypothesis" tests
+	python3 -m pytest -n$(shell nproc) -vv --cov=rflx --cov-branch --cov-fail-under=98.8 --cov-report=term-missing -m "not hypothesis" tests
 
 test_spark: $(test-files)
 	gprbuild -P$(project)

rflx/error.py

@@ -55,9 +55,6 @@ def __lt__(self, other: object) -> bool:
             return self.start < other.start
         return NotImplemented
 
-    def __hash__(self) -> int:
-        return hash(f"{self.__start}:{self.__source}:{self.__end}")
-
     @property
     def source(self) -> Optional[Path]:
         return self.__source
@@ -87,11 +84,6 @@ class Severity(Enum):
     WARNING = 3
     ERROR = 4
 
-    def __gt__(self, other: "Severity") -> bool:
-        # ISSUE: PyCQA/pylint#2306
-        value = int(self.value)
-        return value > other.value
-
     def __str__(self) -> str:
         return str.lower(self.name)
 

rflx/generator/core.py

@@ -884,7 +884,7 @@ def length(field: Field, message: Message) -> Expr:
                 else:
                     if len(links) == 1:
                         length = links[0].length
-                    elif len(links) > 1:
+                    else:
                         length = If(
                             [(l.condition, l.length) for l in links],
                             Variable(const.TYPES_UNREACHABLE_BIT_LENGTH),

rflx/generator/parser.py

@@ -736,8 +736,6 @@ def specification(field: Field) -> ProcedureSpecification:
 def valid_message_condition(
     message: Message, field: Field = INITIAL, structural: bool = False
 ) -> Expr:
-    if not message.outgoing(field):
-        return TRUE
     return Or(
         *[
             l.condition

rflx/model.py

@@ -1098,6 +1098,8 @@ def invalid_relation(left: TypeExpr, right: TypeExpr) -> bool:
                     check_composite_element_range(relation, right, left)
                 elif isinstance(left, Enumeration) and isinstance(right, Enumeration):
                     check_enumeration(relation, left, right)
+            else:
+                assert False, f'unexpected relation type "{type(relation).__name__}"'
 
     def __check_first_expression(self, link: Link, location: Location = None) -> None:
         if link.first != UNDEFINED and not isinstance(link.first, First):

tests/test_cli.py

@@ -4,6 +4,7 @@
 import pkg_resources
 import pytest
 
+import rflx.parser
 from rflx import cli
 from rflx.error import Location, Severity, Subsystem, fail
 
@@ -34,11 +35,16 @@ def test_main_check_parser_error() -> None:
     assert "README.md:1:1: parser: error: " in str(cli.main(["rflx", "check", "README.md"]))
 
 
-def test_main_check_model_error(monkeypatch: Any) -> None:
+def test_main_check_model_error_parse(monkeypatch: Any) -> None:
     monkeypatch.setattr(cli, "check", lambda x: raise_model_error())
     assert "<stdin>:8:22: model: error: TEST" in str(cli.main(["rflx", "check", "README.md"]))
 
 
+def test_main_check_model_error_create_model(monkeypatch: Any) -> None:
+    monkeypatch.setattr(rflx.parser.Parser, "create_model", lambda x: raise_model_error())
+    assert "<stdin>:8:22: model: error: TEST" in str(cli.main(["rflx", "check", "README.md"]))
+
+
 def test_main_check_non_existent_file() -> None:
     assert 'error: file not found: "non-existent file"' in str(
         cli.main(["rflx", "check", "non-existent file"])