Improve window-close scriptlet — use browser extension's API
#170
Assignees
Labels
enhancement
Improvement of existent feature
Release: v1.6.20
Resolution: Done
Status: Closed
Version: Scriptlets v1.6
Comments
ameshkov
changed the title
window.close scriptletwindow-close scriptlet
8 tasks
slavaleleka
changed the title
window-close scriptletwindow-close scriptlet — use browser extension's API
adguard-bot
added
Status: In Progress
Resolution: Fixed
Status: In Review
and removed
Status: In Progress
labels
adguard
pushed a commit
that referenced
this issue
Jun 1, 2022
…AG-11810 Merge in ADGUARD-FILTERS/scriptlets from fix/AG-11810 to master Squashed commit of the following: commit f5457e9 Author: Stanislav A <[email protected]> Date: Mon May 30 18:17:11 2022 +0300 improve close-window scriptlet for chrome
adguard-bot
added
Resolution: Done
Status: Closed
Release: v1.6.2
Release: v1.6.20
and removed
Resolution: Fixed
Status: Resolved
Release: v1.6.2
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It was implemented in #158
However, there're some issues with it in Chrome. The problem is that Chrome limits which scripts can call
window.close. The only way to fix this is to do that via the browser extension's API (using tabs API).I suggest in addition to trying to call
window.closesending a custom event that will be then handled by the content script and passed to the background page. The background page handles this message and closes the window via tabs API.The text was updated successfully, but these errors were encountered: