Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve 'set-cookie' — increase a possible numeric value #388

Closed
ameshkov opened this issue Dec 11, 2023 · 0 comments
Closed

Improve 'set-cookie' — increase a possible numeric value #388

ameshkov opened this issue Dec 11, 2023 · 0 comments
Assignees
@slavaleleka
Labels
enhancement Improvement of existent feature Priority: P4 Release: v1.10.25 Resolution: Fixed Status: Closed Version: AdGuard v4.3.x patch 3 Version: Scriptlets v1.10

Comments

@ameshkov
Copy link
Member

ameshkov commented Dec 11, 2023 •
edited
Loading

Check out the relevant discussion here:
uBlockOrigin/uBlock-issues#3016

We'll need to check allowed constants in all not-trusted set-* scriptlets and make sure they're consistent and similar.

Please don't forget to update the knowledge base.
@ameshkov ameshkov added the enhancement Improvement of existent feature label Dec 11, 2023
@ameshkov ameshkov mentioned this issue Dec 11, 2023
Open
9 tasks
@adguard-bot adguard-bot changed the title Consistent set-* scriptlets limitations Improve 'set-cookie' scriptlets limitations Mar 15, 2024
@adguard-bot adguard-bot changed the title Improve 'set-cookie' scriptlets limitations Improve 'set-cookie' — increase a possible numeric value Mar 15, 2024
adguard pushed a commit that referenced this issue Mar 18, 2024
@slavaleleka
increase the possible numeric value for cookie setting scriptlets. #388…
ec17635 
… AG-28556

Squashed commit of the following:

commit e2ada2e
Merge: 99151f6 ba15220
Author: Slava Leleka <[email protected]>
Date:   Fri Mar 15 18:14:20 2024 +0200

    Merge branch 'master' into fix/AG-28556

commit 99151f6
Merge: 19e1da8 3b581d3
Author: Slava Leleka <[email protected]>
Date:   Fri Mar 15 18:08:42 2024 +0200

    merge master into the branch, resolve conflicts

commit 19e1da8
Author: Slava Leleka <[email protected]>
Date:   Fri Mar 15 18:04:39 2024 +0200

    increase the possible numeric value for cookie setting scriptlets
This was referenced Apr 5, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
enhancement Improvement of existent feature Priority: P4 Release: v1.10.25 Resolution: Fixed Status: Closed Version: AdGuard v4.3.x patch 3 Version: Scriptlets v1.10
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ameshkov @adguard-bot @slavaleleka