Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMAP redirect resource #52

Closed
Alex-302 opened this issue Nov 1, 2019 · 8 comments
Closed

VMAP redirect resource #52

Alex-302 opened this issue Nov 1, 2019 · 8 comments
Assignees
Labels
enhancement Improvement of existent feature Resolution: Done
Milestone

Comments

@Alex-302
Copy link
Member

Alex-302 commented Nov 1, 2019

Current VAST redirect resource cannot be applied in case of using VMAP:
https://gist.github.com/Alex-302/4cf5c5eec322b11350fb24dd01b6c8c1

You can test here(French IP is required)
https://www.canalplus.com/divertissement/tpmp-partie-1/h/8946028_50013

@Alex-302 Alex-302 added the enhancement Improvement of existent feature label Nov 1, 2019
@ameshkov ameshkov modified the milestone: 1.2 Nov 1, 2019
@ameshkov ameshkov added question Further information is requested and removed enhancement Improvement of existent feature labels Nov 1, 2019
@ameshkov
Copy link
Member

ameshkov commented Nov 1, 2019

I don't think this can be handled by a $redirect rule. The problem with VMAP is that it contains links to legitimate videos URLs AND the built-in VAST content. In order to get rid of ads, you need to remove VAST from content, but keep video URLs.

@ameshkov ameshkov closed this as completed Nov 1, 2019
@ameshkov
Copy link
Member

ameshkov commented Nov 1, 2019

Try replacing it with an empty VMAP using $replace rules, does it help?

@Alex-302
Copy link
Member Author

Alex-302 commented Nov 1, 2019

One moment

@Alex-302
Copy link
Member Author

Alex-302 commented Nov 1, 2019

Yes. At least on this site.
||v.fwmrm.net/ad/g/1?*&vpaid=on;$replace=/(<vmap:VMAP[\s\S]*?>)[\s\S]*<\/vmap:VMAP>/\$1<\/vmap:VMAP>/,domain=canalplus.com
image

@ameshkov
Copy link
Member

ameshkov commented Nov 1, 2019

Let's add a VMAP $redirect then, please come up with a proper description of this redirect resource and its syntax.

@ameshkov ameshkov reopened this Nov 1, 2019
@ameshkov ameshkov added this to the 1.2 milestone Nov 1, 2019
@ameshkov ameshkov added enhancement Improvement of existent feature and removed question Further information is requested labels Nov 1, 2019
@Alex-302
Copy link
Member Author

Alex-302 commented Nov 1, 2019

here are two HARs - before and after replacing
https://mega.nz/#!QNVxkaiL!VdQHkFW5HcbCYBbv7J_gpaKfLoq6S6Fcv2wCOkvkbxM

@Alex-302
Copy link
Member Author

Alex-302 commented Nov 1, 2019

noopvmap-1.0
Redirects request to an empty VMAP response.

Example:

||example.org^$xmlhttprequest,redirect=noopvmap-1.0
?
After replacing: <vmap:VMAP version='1.0' xmlns:vmap='http://www.iab.net/vmap-1.0'></vmap:VMAP>

@ameshkov
Copy link
Member

ameshkov commented Nov 1, 2019

Yeah, good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existent feature Resolution: Done
Projects
None yet
Development

No branches or pull requests

5 participants