Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AdGuard's noopvmap-1.0 equivalent as a redirect resource #1425

Closed
8 tasks done
Yuki2718 opened this issue Dec 29, 2020 · 9 comments
Closed
8 tasks done

Add AdGuard's noopvmap-1.0 equivalent as a redirect resource #1425

Yuki2718 opened this issue Dec 29, 2020 · 9 comments
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@Yuki2718
Copy link

Yuki2718 commented Dec 29, 2020

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

AdGuard Japanese addressed AdguardTeam/AdguardFilters#70829 by redirecting XHR to noopvmap-1.0, which indeed works. uBO doesn't have a counterpart so only way to fix this is allowing the request - redirecting to other resources such as noop.txt doesn't work. To be fair, allowing the request doesn't bring actual ads and uBO version of AG Japanese doesn't include the redirect filter so it's not a serious problem but a suggestion.

A specific URL where the issue occurs

https://tver.jp/corner/f0064327 (geo-locked)

Steps to Reproduce

  1. Visit the site using Japanese VPN with uBO and AdGuard (Chromium extension) each.
  2. If you get a modal, close by clicking upper-right X button (or "あとで" on bottom).
  3. Play the video and see AG solution works on AG. No breakage on uBO too as both uBlock Unbreak and AGJPN has whitelist, but if you badfiltered them the player doesn't work. Redirecting to other resources doesn't work either.

Expected behavior:

AG Japanese' redirect works on uBO too.

Actual behavior:

Doesn't work.

Your environment

  • uBlock Origin version: 1.32.0
  • Browser Name and version: Firefox 84.0.1/Brave 1.18.75
  • Operating System and version: Windows 10

Note

I'll remove the whitelist from Unbreak. If this suggestion is accepted and the resource is added, I can make PR on AG for them to include uBO for the target of the redirect filter.

Related:
#1366 (comment)
AdguardTeam/Scriptlets#52

@uBlock-user uBlock-user added the enhancement New feature or request label Dec 29, 2020
@gwarser
Copy link

gwarser commented Dec 29, 2020

https://github.com/AdguardTeam/Scriptlets/blob/bc5eec198903856413e3e114a1d636c34146173d/src/redirects/static-redirects.yml#L134

Basically:

<vmap:VMAP xmlns:vmap="http://www.iab.net/videosuite/vmap" version="1.0"></vmap:VMAP>

@Yuki2718
Copy link
Author

Of note, AG Base has 2 filters redirecting to this. They excludes uBO.

!+ NOT_PLATFORM(ext_ff, ext_ublock)
||v.fwmrm.net/ad/g/1?resp=$xmlhttprequest,redirect=noopvmap-1.0,domain=viafree.dk,important
!+ NOT_PLATFORM(ext_ublock)
||api.jtbc.joins.com/ad/vmap/*$xmlhttprequest,redirect=noopvmap-1.0,domain=tv.jtbc.joins.com,important

@uBlock-user
Copy link
Contributor

They also have noopvast, what does that help fix ?

@uBlock-user uBlock-user added the fixed issue has been addressed label Dec 29, 2020
@gorhill
Copy link
Member

gorhill commented Dec 29, 2020

I could not test that it works, feedback about this is welcome.

@Yuki2718
Copy link
Author

Yuki2718 commented Dec 29, 2020

Shortly tested on Firefox, the player doesn't work but AG also excludes Firefox:

!+ PLATFORM(windows, mac, android, ext_chromium)
||pubads.g.doubleclick.net/gampad/ads?*&output=xml_vmap$xmlhttprequest,redirect=noopvmap-1.0,domain=tver.jp
Screenshot

tver

I'll test on Chromium tomorrow.

@Yuki2718
Copy link
Author

Working fine on Chrome:

tver

So there must be reason that AG guys excluded Firefox. Maybe we can add Firefox-specific whitelist in Unbreak, but then the benefit of this resource will be halved - only for Chromium.

@uBlock-user
Copy link
Contributor

on viafree.dk CORS is preventing data: resources from getting loaded on Firefox.

JustOff added a commit to gorhill/uBlock-for-firefox-legacy that referenced this issue Jan 25, 2021
Related issue:
- uBlockOrigin/uBlock-issues#1425

The resource content is a copy/paste of AdGuard's code:
- https://github.com/AdguardTeam/Scriptlets/blob/bc5eec198903856413e3e114a1d636c34146173d/src/redirects/static-redirects.yml#L134

Related commit:
- gorhill/uBlock@1669d12

Co-authored-by: Raymond Hill <rhill@raymondhill.net>
@Yuki2718
Copy link
Author

Yuki2718 commented Mar 25, 2024

They also have noopvast, what does that help fix ?

On https://funny-ai.com/46133611 after you uploaded a face photo and then clicked "ランキングを見る" button, I confirmed ||serving.stat-rock.com/v1/placements/$xmlhttprequest,domain=funny-ai.com,redirect=noopvast-3.0 can be used instead of an exception and media redirect I added in AdguardTeam/AdguardFilters@04aca97 to see rankings. noopvast works but shows error so I didn't added the rule even for AG just in case, but this can be used as a real case to test.

error

@Yuki2718
Copy link
Author

Fully fixed with gorhill/uBlock@59a9a43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

4 participants