Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ITT-556]Regenerated binlookup and fix tests #1176

Merged
merged 9 commits into from
Jun 23, 2023
Merged

[ITT-556]Regenerated binlookup and fix tests #1176

merged 9 commits into from
Jun 23, 2023

Conversation

jillingk
Copy link
Contributor

@jillingk jillingk commented Jun 2, 2023

Description
Regenerate binlookup.

@jillingk jillingk requested a review from a team as a code owner June 2, 2023 07:56
wboereboom
wboereboom requested changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@wboereboom wboereboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also bump the version numbers in the README

wboereboom
wboereboom requested changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@wboereboom wboereboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also bump the version numbers in the README

michaelpaul
michaelpaul previously approved these changes Jun 6, 2023
View reviewed changes
@michaelpaul michaelpaul added the Breaking change This change introduces breaking changes label Jun 6, 2023
michaelpaul
michaelpaul previously approved these changes Jun 15, 2023
View reviewed changes
@jillingk jillingk requested a review from a team June 23, 2023 06:28
wboereboom
wboereboom previously approved these changes Jun 23, 2023
View reviewed changes
@jillingk jillingk enabled auto-merge (squash) June 23, 2023 07:41
wboereboom
wboereboom previously approved these changes Jun 23, 2023
View reviewed changes
AlexandrosMor
AlexandrosMor previously approved these changes Jun 23, 2023
View reviewed changes
@jillingk jillingk dismissed stale reviews from AlexandrosMor and wboereboom via 1c126c8 June 23, 2023 08:47
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jillingk jillingk merged commit 0e65ac0 into develop Jun 23, 2023
10 checks passed
@jillingk jillingk deleted the ITT-556-BINLOOKUP branch June 23, 2023 12:22
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request Jun 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandrosMor AlexandrosMor AlexandrosMor approved these changes

@antolo-arch antolo-arch antolo-arch approved these changes

@michaelpaul michaelpaul michaelpaul left review comments

@wboereboom wboereboom Awaiting requested review from wboereboom

Assignees
No one assigned
Labels
Breaking change This change introduces breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jillingk @michaelpaul @AlexandrosMor @antolo-arch @wboereboom