Fix ForceEntryMode typings #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wboereboom
approved these changes
Jun 19, 2023
AlexandrosMor
approved these changes
Jun 19, 2023
|
Hello @Meisolsson, Thanks for your contribution. It seems like there has been some error during the generation of these fields. Good catch! Kind Regards, |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change typings of ForceEntryMode to Array`` instead of
Array<Array<ForceEntryModeEnum>>.The files say that they are generated but seems like that is just copied as nothing seems to generate them and other people have manually changed them before.
Tested scenarios
I have tested this on a local terminal both with and without any ForceEntryMode set. Both works as expected.
Fixed issue: #1184