add install devDependencies to Makefile commands #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jillingk
previously approved these changes
Jun 27, 2023
jillingk
previously approved these changes
Jun 27, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
michaelpaul
approved these changes
Jun 28, 2023
antolo-arch
approved these changes
Jun 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix addresses the failing npx command in the Models workflow that has been throwing errors over the past few months.
The
npxcommand is not able to deal with eslint configuration, and will not download the plugins required to succesfully perform theeslintcommand as can be seen in this workflow run. Pre-installing devDependencies ensures the plugins are present when theeslintcommand is performedTested scenarios
Tested running the npx eslint command locally without having npm modules pre-installed