Cancel Without Resume Data When Possible #3538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jshier
force-pushed
the
bug/unnecessary-download-data
branch
from
f3681ad
to
4c5a292
Compare
jshier
force-pushed
the
bug/unnecessary-download-data
branch
from
4c5a292
to
6f9d274
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
#3536
Goals ⚽
This PR reverts the fix from #3102 as the underlying bug doesn't seem to actually affect Alamofire, perhaps due to our use of locking around cancellation.
Implementation Details 🚧
Just call
cancel()rather thancancel(producingResumeData:)with an empty closure, as doing so produced resume data unconditionally and won't be cleaned up until temp storage is purged.Testing Details 🔍
Original tests intact, nothing new. Should continue passing on all OSes. Added older OS coverage in another PR to ensure that
DownloadRequest's tests continue to pass.