Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add some missing treesitter hl groups #23

Merged
merged 3 commits into from
Jan 24, 2023
Merged

feat: add some missing treesitter hl groups #23

merged 3 commits into from
Jan 24, 2023

Conversation

NTBBloodbath
Copy link
Contributor

Hey, I've been playing around with the colorscheme and some code I had and it seems like html files does not have highlighting at all when using the treesitter parser so I've added some missing highlighting groups to fix that behavior and also some life quality improvements for markup languages (adding more @text groups) :p

HTML files before:
image

HTML files after:
image

@AlexvZyl
Copy link
Owner

AlexvZyl commented Jan 24, 2023

Awesome, thanks! I do not work with web tech (atm at least) so I might have missed quite a few things.

Just one note (and gonna sound board now): I am using red sparingly, as I want red to represent 'dangerous' or 'important' things. For example, exception handling (try, catch) or macros (especially in C and C++, they can be buggers) so I would suggest changing the red to something else? Maybe yellow.base?

@NTBBloodbath
Copy link
Contributor Author

Just one note (and gonna sound board now): I am using red sparingly, as I want red to represent 'dangerous' or 'important' things. For example, exception handling (try, catch) or macros (especially in C and C++, they can be buggers) so I would suggest changing the red to something else? Maybe yellow.base?

Sure thing, let me change it very quickly!

@AlexvZyl
Copy link
Owner

Yellow already seems brighter than the rest of the colors, so making it bold might be a bit too much. Do you mind posting what it looks like?

@NTBBloodbath
Copy link
Contributor Author

Just tested it again and it seems like bold is not really needed here as yellow is brighter than the rest of colors as you've said so removed it

@AlexvZyl
Copy link
Owner

Awesome, thanks again!

@AlexvZyl AlexvZyl merged commit 98a65d1 into AlexvZyl:main Jan 24, 2023
@AlexvZyl AlexvZyl added the Enhancement New feature, request or suggestion label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature, request or suggestion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants