Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparency support & fix testing in a PR #28

Merged
merged 21 commits into from
Jan 27, 2023
Merged

Conversation

lcrownover
Copy link
Contributor

@lcrownover lcrownover commented Jan 26, 2023

Added override table

This table can be used to override color and styling of any element.

Redesigned the syntax config to operate more like the original Nord theme

The functionality of the syntax table was maintained, but now with the override table, you can enable/disable bold/italic on particular items, if the general bold or italic booleans don't do what you want.

Added transparency config option

This option sets a few key element backgrounds to c.none for a cohesive transparent style. You can always use the override table to enable/disable transparency in a more surgical manner.

@lcrownover
Copy link
Contributor Author

Fixed merge conflict with the README.

@AlexvZyl
Copy link
Owner

Ah, awesome! I was planning on doing this, thanks!

Will test it a bit later.

Also, I see my CI is not working correctly. Gonna try and fix that.

@AlexvZyl AlexvZyl added the Enhancement New feature, request or suggestion label Jan 26, 2023
@AlexvZyl AlexvZyl changed the title Enable transparency support Feat: Transparency support Jan 26, 2023
@AlexvZyl
Copy link
Owner

AlexvZyl commented Jan 26, 2023

That's wrong. Just trying to figure out how to get lcrownover/nordic.nvim.

@AlexvZyl
Copy link
Owner

Cool, working beautifully now. A bit messy, I will clean it up a bit later.

@AlexvZyl AlexvZyl changed the title Feat: Transparency support Transparency support & fix testing from a fork Jan 26, 2023
@AlexvZyl AlexvZyl changed the title Transparency support & fix testing from a fork Transparency support & fix testing in a PR Jan 26, 2023
@lcrownover
Copy link
Contributor Author

Nice! Let me know if there's any adjustments you'd like to see, happy to adapt.

@AlexvZyl AlexvZyl merged commit 65bde55 into AlexvZyl:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature, request or suggestion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants