Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platforms): add support for fish shell #70

Merged
merged 3 commits into from
Aug 3, 2023
Merged

feat(platforms): add support for fish shell #70

merged 3 commits into from
Aug 3, 2023

Conversation

XXiaoA
Copy link
Contributor

@XXiaoA XXiaoA commented Jul 12, 2023

Screenshot_2023-07-12-16-00-43

@AlexvZyl AlexvZyl added the Enhancement New feature, request or suggestion label Jul 12, 2023
@AlexvZyl AlexvZyl self-assigned this Jul 12, 2023
@AlexvZyl
Copy link
Owner

AlexvZyl commented Jul 18, 2023

Today I learned about fish_config :)

A few things I think should be the case:

  • Strings should be green
  • Comments should be gray4
  • Autosuggestions should be gray3 (probably not the same as comments)
  • Normal typing should either be white0 or blue1
  • Maybe use yellow or orange for operators and functions

What do you think?

@XXiaoA
Copy link
Contributor Author

XXiaoA commented Jul 18, 2023

@AlexvZyl Thx for ur advice. I tried gray3 for autosuggesting, but it is too dim, i think.
图片

Maybe gray5 is more suitable ?
图片

@XXiaoA
Copy link
Contributor Author

XXiaoA commented Jul 18, 2023

I tweak a lot.

simplescreenrecorder-2023-07-18_21.38.48.mp4

@XXiaoA
Copy link
Contributor Author

XXiaoA commented Jul 18, 2023

Ummm orange looks like red which refer to error of param. Yellow is easier to tell between error and normal, i think.
图片
图片

@AlexvZyl
Copy link
Owner

I did not forget about this PR. Would you mind showing me a screenshot of what the final product looks like? Sorry for leaving you hanging.

@XXiaoA
Copy link
Contributor Author

XXiaoA commented Jul 30, 2023

Here.
图片

Anything else should be adjusted?

@AlexvZyl
Copy link
Owner

This color seems off.
image
Can you make that the normal orange?

@XXiaoA
Copy link
Contributor Author

XXiaoA commented Jul 30, 2023

This color seems off. image Can you make that the normal orange?

This git status are showed by starship, which is not related to fish. 🤣
https://github.com/XXiaoA/dotfiles/blob/f514270e01ad590cdbfb5fdac347f9fe64144101/starship/starship.toml#L13

@AlexvZyl
Copy link
Owner

Did you set the terminal colors? Because both fish and starship should be using the terminal colors.

@XXiaoA
Copy link
Contributor Author

XXiaoA commented Jul 31, 2023

I don't remember I set the terminal colors manually.

@AlexvZyl
Copy link
Owner

AlexvZyl commented Aug 3, 2023

Hmm... Becase now that I think of it, you actually want to set the terminal colors and not each component running in the terminal. What terminal are you using?

@XXiaoA
Copy link
Contributor Author

XXiaoA commented Aug 3, 2023

Wezterm. And I have used nordic's wezterm theme

@AlexvZyl AlexvZyl merged commit 1c69136 into AlexvZyl:main Aug 3, 2023
1 check passed
@AlexvZyl
Copy link
Owner

AlexvZyl commented Aug 3, 2023

There might be some colors missing in the wezterm theme I think.

@XXiaoA
Copy link
Contributor Author

XXiaoA commented Aug 3, 2023

Okay. Anyway, thanks for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature, request or suggestion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants