Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-source to in-wiki link transformer for v5 #73

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

jcbhmr
Copy link
Collaborator

@jcbhmr jcbhmr commented Jul 16, 2023

This way, it gets added to v5 as a BREAKING change since this actually does legitimately change the way this action works:

  • It's no longer zero-copy
  • It affects the deployed content in a way that may be unexpected to users.

@jcbhmr jcbhmr self-assigned this Jul 16, 2023
@jcbhmr jcbhmr marked this pull request as ready for review July 16, 2023 22:07
@jcbhmr
Copy link
Collaborator Author

jcbhmr commented Jul 16, 2023

I'm merging this back into "master" so that "master" is being prepared for v5, but there's still the locked-in v4.4.0 version of the old bash-based zero-copy way.

This is how I should have done things from the start, but I didn't because I'm a bit of a dum dum.

@jcbhmr jcbhmr merged commit 86138cb into master Jul 16, 2023
8 checks passed
@jcbhmr jcbhmr deleted the revert-72-revert-68-in-source-to-in-wiki-links branch July 16, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant