Directory scanning performance improvements #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
AnonymouX47
commented
Mar 29, 2022
•
AnonymouX47
commented
- Addresses Scanning directories and loading animated images too slow #10
- Improves directory entry sorting & scanning
- Improves menu listing and grid scanning
- Groups directory entries before image entries
- Add: Adds `.tui.main.UNKNOWN` constant for `scan_dir_*` functions. - Change: Updates `.tui.main.sort_key_lexi()`. - Now accepts `os.DirEntry` or `pathlib.Path` instances instead of strings. - Change: Updates `.tui.main.scan_dir_entry()`. - Now accepts `os.DirEntry` or `pathlib.Path` instances instead of strings for directory entries. - Other minor performance optimizations. - Change: Significantly improves directory entry sorting and scanning performance. - Leverages `os.DirEntry`'s stat caching to eliminate system calls by `os.path.isfile()`. - Change: Updates docstrings.
- Change: Updates `.tui.main.scan_dir()`. - Adds *last_entry* and *sort_key* parameters for improved functionality. - Replaces `os.listdir()` with `os.scandir()` for significant performance improvements. - Now yeilds the entry typecode along with the item tuple. - Now yeilds all scanned entries, no matter the type to allow for better control within it's caller. - Change: Updates docstrings.
- Change: Updates `scan_dir_grid()` and `scan_dir_menu()` in `.tui.main`. - Both functions now utilize `.tui.main.scan_dir()`. - Change: Updates docstrings.
AnonymouX47
added
the
enhancement
- Fix: Fixed `scan_dir_grid()` appending to the grid scan list after the grid has changed. - Occured when switching to an empty grid before the current grid scan is done. - `scan_dir_grid()` now uses an alias to the grid scan list, which is updated (with `.tui.main._grid_list`) only when changing grids. - Change: Renamed `.tui.main.grid_list` to `.tui.main._grid_list`.
AnonymouX47
added
the
tui
- Change: Grouped directories before files. - Change: Removed unnecessary code. - Change: Updated docstrings and comments.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.