Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to image animation #22

Merged
merged 5 commits into from
Apr 10, 2022
Merged

Improvements to image animation #22

merged 5 commits into from
Apr 10, 2022

Conversation

AnonymouX47
Copy link
Owner

@AnonymouX47 AnonymouX47 commented Apr 7, 2022 •
edited
Loading

  • Restores frame caching based on framecount formerly reverted by ea6f74b and 97464fd
  • Replaces frame caching based on filesize
  • Removes optimizations for animated images which are no longer necessary
  • Fixes TUI image animation
  • Adds command-line options for controlling animation repeat count and animation frame caching

Pillow v9.1.0 has been released with the improvements in python-pillow/Pillow#6077

@AnonymouX47
[lib] Revert "Optimizations for animated images"
e1edbd4 
This **partially** reverts commit 968e6e2.
@AnonymouX47 AnonymouX47 added enhancement New feature / Improvement suggestion or request lib Related to the library (Not to be used anymore) cli Related to the image viewer's CLI (Not to be used anymore) tui Related to the image viewer's TUI (Not to be used anymore) labels Apr 7, 2022
@AnonymouX47 AnonymouX47 added this to the 0.2.0 milestone Apr 7, 2022
@AnonymouX47
Restored animation frame caching criteria
355d94a 
- Change: This brings back frame caching based on framecount.

This reverts commits ea6f74b and 97464fd.
@AnonymouX47
[tui] Fixed TUI image animation
2924fec 
- Fix: Corrected behaviour after switching from and back to an animated image within one frame duration.
  - The animation starts afresh.
  - Only one animation is ongoing i.e the frames are not being changed by multiple alarms or multiple times within a single frame duration.
  - `image._animator` and other animation attributes are now properly cleaned up.
@AnonymouX47
[cli,tui] Added animation repeat count option
b4dce31 
- Add: Added a group for animation-related CLI options.
- Add: Added `-R | --repeat` CLI option.
- Add: Incoporated animation repeat count into the CLI and TUI.
- Add: Added `.tui.main.REPEAT`.
@AnonymouX47
[cli,tui] Added animation caching options
8aafa80 
- Add: Added `--anim-cache`, `--cache-all-anim` and `--cache-no-anim` CLI options.
- Add: Incoporated animation frame caching options into the CLI and TUI.
@AnonymouX47 AnonymouX47 merged commit 52099aa into main Apr 10, 2022
@AnonymouX47 AnonymouX47 deleted the animation branch April 10, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cli Related to the image viewer's CLI (Not to be used anymore) enhancement New feature / Improvement suggestion or request lib Related to the library (Not to be used anymore) tui Related to the image viewer's TUI (Not to be used anymore)
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@AnonymouX47