-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded to 2.0 of Apicurio Data Models #3100
Closed
EricWittmann
wants to merge
16
commits into
Apicurio:main
from
EricWittmann:feat/upgrade-apicurio-data-models
Closed
Upgraded to 2.0 of Apicurio Data Models #3100
EricWittmann
wants to merge
16
commits into
Apicurio:main
from
EricWittmann:feat/upgrade-apicurio-data-models
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for creating a pull request! Pinging @jsenko to respond or triage. |
carlesarnal
reviewed
Jan 25, 2023
@@ -238,8 +238,7 @@ private boolean accessTokenIsCached(String credentialsHash) { | |||
|
|||
@Retry(retryOn = AuthException.class, maxRetries = 4) | |||
public String getAccessToken(Pair<String, String> clientCredentials, String credentialsHash) { | |||
OidcAuth oidcAuth = new OidcAuth(httpClient, clientCredentials.getLeft(), clientCredentials.getRight()); | |||
try { | |||
try (OidcAuth oidcAuth = new OidcAuth(httpClient, clientCredentials.getLeft(), clientCredentials.getRight())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change.
carlesarnal
approved these changes
Jan 25, 2023
Bumps [proto-google-common-protos](https://github.com/googleapis/gapic-generator-java) from 2.12.0 to 2.13.0. - [Release notes](https://github.com/googleapis/gapic-generator-java/releases) - [Changelog](https://github.com/googleapis/gapic-generator-java/blob/main/CHANGELOG.md) - [Commits](googleapis/sdk-platform-java@v2.12.0...v2.13.0) --- updated-dependencies: - dependency-name: com.google.api.grpc:proto-google-common-protos dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
* docs: minor clean up from downstream testing * docs: clean up contrib doc, fix a few typos
Bumps [api](https://github.com/strimzi/strimzi-kafka-operator) from 0.32.0 to 0.33.0. - [Release notes](https://github.com/strimzi/strimzi-kafka-operator/releases) - [Changelog](https://github.com/strimzi/strimzi-kafka-operator/blob/main/CHANGELOG.md) - [Commits](strimzi/strimzi-kafka-operator@0.32.0...0.33.0) --- updated-dependencies: - dependency-name: io.strimzi:api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps debezium-core from 1.9.6.Final to 2.1.2.Final. --- updated-dependencies: - dependency-name: io.debezium:debezium-core dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.