Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

also run tests on net7 #1010

Merged
merged 2 commits into from
Jan 9, 2023
Merged

also run tests on net7 #1010

merged 2 commits into from
Jan 9, 2023

Conversation

SimonCropp
Copy link
Contributor

I wasnt sure if we should still run tests on net6?

@codecov-commenter

This comment was marked as outdated.

Sign in to view
martincostello
martincostello approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As 6 is LTS and 7 isn't, IMHO we should test both if we test with 7.

@SimonCropp
Copy link
Contributor Author

As 6 is LTS and 7 isn't, IMHO we should test both if we test with 7.

@martincostello done

@SimonCropp SimonCropp merged commit 7e988d6 into main Jan 9, 2023
@SimonCropp SimonCropp deleted the also-run-tests-on-net7 branch January 9, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martincostello martincostello martincostello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonCropp @codecov-commenter @martincostello