Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add notes to use Polly.RateLimiting package #1672

Conversation

peter-csala
Copy link
Contributor

@peter-csala peter-csala commented Oct 3, 2023

Details on the issue fix or feature implementation

  • The migration document does not mention explicitly that the new rate limiting strategies reside in a different package than the rest of the strategies.
  • I've added notes to doc to help people with the migration process.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6ce4ee0) 84.63% compared to head (8ba239b) 84.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1672   +/-   ##
=======================================
  Coverage   84.63%   84.63%           
=======================================
  Files         306      306           
  Lines        6819     6819           
  Branches     1045     1045           
=======================================
  Hits         5771     5771           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 84.63% <ø> (ø)
windows 84.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/migration-v8.md Outdated Show resolved Hide resolved
@martintmk martintmk enabled auto-merge (squash) October 3, 2023 07:51
@martintmk martintmk merged commit 5a0e9bc into App-vNext:main Oct 3, 2023
14 checks passed
@peter-csala peter-csala deleted the add-notes-to-the-migration-doc-about-ratelimiter branch October 31, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants