Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Include info about numerical type used in metrics in telemetry.md #1673

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

agehrke
Copy link
Contributor

@agehrke agehrke commented Oct 3, 2023

Pull Request

This PR adds info about the numerical type used for the three metrics. This is useful to know if you use the MeterListener class which requires you to specify the measurement type when calling SetMeasurementEventCallback<T>().

The issue or feature being addressed

Improve documentation of metrics.

Details on the issue fix or feature implementation

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@agehrke
Copy link
Contributor Author

agehrke commented Oct 3, 2023

@dotnet-policy-service agree

@martincostello martincostello enabled auto-merge (squash) October 3, 2023 08:39
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6ce4ee0) 84.63% compared to head (a8e9968) 84.63%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1673   +/-   ##
=======================================
  Coverage   84.63%   84.63%           
=======================================
  Files         306      306           
  Lines        6819     6819           
  Branches     1045     1045           
=======================================
  Hits         5771     5771           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 84.63% <ø> (ø)
windows 84.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit eb56dcc into App-vNext:main Oct 3, 2023
14 checks passed
@agehrke agehrke deleted the numerical-type-info branch October 4, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants