Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run mutation tests on Windows instead of Linux #1752

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

martincostello
Copy link
Member

As discovered in #1738, there's an issue with Stryker with .NET 8 that breaks it on Linux and macOS, so run on Windows until that's resolved.

Doing this as a separate PR to reduce the scope of the changes needed ahead of our actual support for .NET 8.

As discovered in #1738, there's an issue with Stryker with .NET 8 that breaks it on Linux and macOS, so run on Windows until that's resolved.
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41d4e8d) 84.56% compared to head (0c33bf4) 84.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1752   +/-   ##
=======================================
  Coverage   84.56%   84.56%           
=======================================
  Files         307      307           
  Lines        6790     6790           
  Branches     1043     1043           
=======================================
  Hits         5742     5742           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.56% <ø> (ø)
macos 84.56% <ø> (ø)
windows 84.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk
Copy link
Contributor

The downside is that this will slow-down our builds :/

@martincostello
Copy link
Member Author

The downside is that this will slow-down our builds :/

I think for 3 minutes extra it's fine 😅

@martincostello martincostello merged commit 41e06e4 into main Oct 30, 2023
18 checks passed
@martincostello martincostello deleted the mutation-on-windows branch October 30, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants