Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not encourage re-throwing the same exception instance #1900

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jan 17, 2024

Details on the issue fix or feature implementation

Follow-up of #1899

Our APIs should not encourage re-throwing cached exception as it causes the stack trace to grow uncontrollably (#1877).

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added this to the v8.3.0 milestone Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d78805) 84.66% compared to head (40854a8) 84.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1900      +/-   ##
==========================================
- Coverage   84.66%   84.65%   -0.02%     
==========================================
  Files         309      309              
  Lines        6833     6828       -5     
  Branches     1052     1050       -2     
==========================================
- Hits         5785     5780       -5     
  Misses        839      839              
  Partials      209      209              
Flag Coverage Δ
linux 84.65% <100.00%> (-0.02%) ⬇️
macos 84.65% <100.00%> (?)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk martintmk enabled auto-merge (squash) January 17, 2024 16:30
@martintmk martintmk merged commit dc8248d into main Jan 17, 2024
14 checks passed
@martintmk martintmk deleted the mtomka/simmy-api-cleanup branch January 17, 2024 16:54
@peter-csala peter-csala mentioned this pull request Jan 19, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants