Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simmy API review Part 4 - Rename BehaviorAction to BehaviorGenerator #1917

Conversation

peter-csala
Copy link
Contributor

Pull Request

The issue or feature being addressed

#1901

Details on the issue fix or feature implementation

  • Renamed BehaviorAction to BehaviorGenerator
  • Added code samples for the related anti pattern

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@peter-csala peter-csala changed the title Simmy API review Part 4 - Rename behavioraction to behaviorgenerator Simmy API review Part 4 - Rename BehaviorAction to BehaviorGenerator Jan 23, 2024
@martincostello martincostello added this to the v8.3.0 milestone Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74f0a72) 84.80% compared to head (e9e48a5) 84.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1917   +/-   ##
=======================================
  Coverage   84.80%   84.80%           
=======================================
  Files         312      312           
  Lines        6897     6897           
  Branches     1056     1056           
=======================================
  Hits         5849     5849           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.80% <100.00%> (?)
macos 84.80% <100.00%> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk martintmk enabled auto-merge (squash) January 23, 2024 12:25
@martintmk martintmk merged commit 5897459 into App-vNext:main Jan 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants