Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CA1806 #1963

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Fix CA1806 #1963

merged 3 commits into from
Feb 8, 2024

Conversation

gintsk
Copy link
Contributor

@gintsk gintsk commented Feb 8, 2024

Pull Request

The issue or feature being addressed

Contributes to #1290

Details on the issue fix or feature implementation

Formal fix for CA1806: Do not ignore method results

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f40164) 85.91% compared to head (479df20) 85.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1963   +/-   ##
=======================================
  Coverage   85.91%   85.91%           
=======================================
  Files         312      312           
  Lines        6654     6654           
  Branches     1057     1057           
=======================================
  Hits         5717     5717           
  Misses        540      540           
  Partials      397      397           
Flag Coverage Δ
linux 85.91% <ø> (ø)
macos 85.91% <ø> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello enabled auto-merge (squash) February 8, 2024 21:23
@martincostello
Copy link
Member

Thanks again!

@martincostello martincostello added this to the v8.3.1 milestone Feb 8, 2024
@martincostello martincostello merged commit 29086a3 into App-vNext:main Feb 8, 2024
14 checks passed
@gintsk gintsk deleted the cleanup branch February 8, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants