Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release argodata 0.1.0 #25

Open
3 of 24 tasks
paleolimbot opened this issue Apr 14, 2021 · 8 comments
Open
3 of 24 tasks

Release argodata 0.1.0 #25

paleolimbot opened this issue Apr 14, 2021 · 8 comments

Comments

@paleolimbot
Copy link
Collaborator

paleolimbot commented Apr 14, 2021

First release:

Prepare for release:

  • devtools::build_readme()
  • urlchecker::url_check()
  • devtools::check(remote = TRUE, manual = TRUE)
  • devtools::check_win_devel()
  • rhub::check_for_cran()
  • Review pkgdown reference index for, e.g., missing topics
  • Draft blog post

Submit to CRAN:

  • usethis::use_version('minor')
  • devtools::submit_cran()
  • Approve email

Wait for CRAN...

  • Accepted 🎉
  • usethis::use_github_release()
  • usethis::use_news_md()
  • usethis::use_dev_version()
  • Update install instructions in README
  • Finish blog post
  • Tweet
  • Add link to blog post in pkgdown news menu
@paleolimbot
Copy link
Collaborator Author

@richardsc @cgrdn @j-harbin @dankelley

There's no rush on a CRAN release of argodata, but it's looped through the 3 million Argo files a few times and the structure has been stable for a few months now. My personal roadmap was to wait until the FMS paper is published and argoFloats is on CRAN (with the related fanfare) to write/tweet anything about argodata but I've never discussed it with any of you. A quiet early CRAN release can be a good thing (my preference) to get the submission process out of the way.

If you all are comfortable, I'd love to add you all as authors since it's the ideas in argoFloats and general Argo discussions that formed the basis for this package. Let me know what you think!

@cgrdn
Copy link
Contributor

cgrdn commented Apr 15, 2021

Hi Dewey, that all sounds great and I would be very happy to be included as an author - thanks so much.

@j-harbin
Copy link

Hi Dewey!

First of all, thanks for thinking of us :). Just to confirm, do you want us to be co-authrors on a paper or the package? I would hate to take away your credit for the package (as I haven't written any code for you), but by all means I'd love to be a co-author of an argodata paper.

Let me know what you think!

@paleolimbot
Copy link
Collaborator Author

Both! I don't know if there will be a paper...I'm certainly happy to write one but Clark owns my time and we haven't discussed if that's one my my priorities during my contract. I happen to think that writing code is a small part of total contributions to a package and without (all of) your emails about Argo and lively discussions on the argoFloats issue threads I would never have known what problems needed solving. This package uses different data structures and is written for users with different expectations than argoFloats, but I would say the majority of the ideas didn't come from me even if I did write the code.

If you're sure, I'm happy to omit you from "author" status (but I personally feel you deserve it).

@dankelley
Copy link

Hm, Dewey, you make a convincing re authorship. In R, a person can be an author, a contributor, etc. so for the package, I think it's you for author and the others as contributors (or whatever category seems to fit).

We plan to submit argoFloats to CRAN after the Frontiers paper is actually published, and maybe after the JOSS paper is accepted, also. (My thinking is that CRAN acceptance might be more likely if we have papers using the package. I don't want to get into a begging situation with CRAN.)

Since Frontiers is at the corrected-galley-proof stage, I imagine it will come out in a week or two. (Our changes to the galleys would take maybe 5 minutes for the typesetter.). We have JOSS just about ready for submission, but one of our checklist items is to have a final citation for the Frontiers paper, so we are waiting on that. I've reviewed for JOSS before and I think they are very quick. My guess, then, is that we'll submit argoFloats to CRAN in about a month.

paleolimbot pushed a commit that referenced this issue Apr 16, 2021
paleolimbot pushed a commit that referenced this issue Apr 16, 2021
@paleolimbot
Copy link
Collaborator Author

You're all "contributor"s now! I'll aim for a CRAN submission after argoFloats in a few months.

@paleolimbot
Copy link
Collaborator Author

Also, you're going to have zero problems with the CRAN submission but one of the questions they do ask for new contributors is whether or not there are articles you should be citing in your DESCRIPTION (so the doi for the Frontiers paper will help you theere).

@j-harbin
Copy link

Thanks for thinking of us Dewey 👍. And thanks for the tip about CRAN. I've never actually released to CRAN before, but this will be a learning experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants