Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn around compress default #111

Closed
ArneBachmann opened this issue Jan 3, 2018 · 2 comments
Closed

Turn around compress default #111

ArneBachmann opened this issue Jan 3, 2018 · 2 comments
Labels
enhancement good first issue question
Milestone
1.2

Comments

@ArneBachmann
Copy link
Owner

sos offline --compress instead
But first test on a different fle system (NTFS)
@ArneBachmann ArneBachmann added this to the 1.2 milestone Jan 3, 2018
@ArneBachmann
Copy link
Owner Author

ArneBachmann commented Jan 4, 2018 •
edited

Required to add #113

@ArneBachmann
Copy link
Owner Author

ArneBachmann commented Jan 4, 2018 •
edited

It seems on Windows copying is also 10x faster than compression. Otherwise the default should be depending on the underlying file system (COW or not), but this is not easy to determine.
https://stackoverflow.com/questions/25283882/determining-the-filesystem-type-from-a-path-in-python
I will create a pip package that provides a function isCowFs(path:str) -> bool, but the compression option should be off by default.

ArneBachmann added a commit that referenced this issue Jan 4, 2018
@ArneBachmann
Fixes #113. Fixes #111.
ec62d76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue question
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
1 participant
@ArneBachmann