Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What about move/renames? not supported for each offline state #8

Closed
ArneBachmann opened this issue Oct 23, 2017 · 5 comments
Closed

What about move/renames? not supported for each offline state #8

ArneBachmann opened this issue Oct 23, 2017 · 5 comments
Assignees
@ArneBachmann
Labels
feature
Milestone
1.1

Comments

@ArneBachmann
Copy link
Owner

No description provided.

@ArneBachmann
Copy link
Owner Author

Could be implemented as simple rm / rename / add (tracked files)

@ArneBachmann
Copy link
Owner Author

ArneBachmann commented Nov 12, 2017 •
edited
Loading

Only relevant in tracking or picky mode, simple mode simply picks up any changes anyway.
In tracking mode, however, rename would only work if there's an explicit tracking pattern, not a glob pattern that matches the renamed file or folder, or we have to include complex detection logic to take care of that.

@ArneBachmann ArneBachmann added this to the Future milestone Nov 13, 2017
@ArneBachmann
Copy link
Owner Author

Since in simple mode not necessary, we could turn this around in renaming tracking patterns first-hand and checking what files might be affected and need renaming too, with some intelligent hints.

@ArneBachmann ArneBachmann modified the milestones: Future, 1.1 Dec 14, 2017
ArneBachmann added a commit that referenced this issue Dec 21, 2017
@ArneBachmann
Preparing issue #8
2001603
@ArneBachmann
Copy link
Owner Author

Don't forget to create dirs if necessary

@ArneBachmann
Copy link
Owner Author

Working on it

@ArneBachmann ArneBachmann mentioned this issue Dec 25, 2017
Closed
@ArneBachmann ArneBachmann self-assigned this Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArneBachmann ArneBachmann

Labels
feature
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
1 participant
@ArneBachmann