Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'CallOrCreateInfo' to 'ValidatedTransaction' apply result #85

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Add 'CallOrCreateInfo' to 'ValidatedTransaction' apply result #85

merged 1 commit into from
Jul 10, 2023

Conversation

shaunxw
Copy link
Member

@shaunxw shaunxw commented Jul 10, 2023 •
edited by ashutoshvarma
Loading

  1. Add CallOrCreateInfo to apply result of ValidatedTransaction, to support XVM call result query.
  2. Make Pending storage public, which is to revert the breaking change in Frontier 0.9.40, to support Remote & Cross-VM Ethereum transaction support Astar#967

Upstream PR - polkadot-evm#1099

Dinonard
Dinonard approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Will you also make a PR to the upstream?

@shaunxw
Copy link
Member Author

shaunxw commented Jul 10, 2023

Yes, I've made a PR to the upstream for ValidatedTransaction polkadot-evm#1099. Forgot to link in the description. 😅

For Pending storage visibility, the upstream deliberately changed it, so I guess they won't accept PRs to revert it back.

@shaunxw shaunxw merged commit e2f5879 into polkadot-v0.9.40 Jul 10, 2023
5 checks passed
@shaunxw shaunxw deleted the feat/apply-result-extra-info branch July 10, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinonard Dinonard Dinonard approved these changes

@ashutoshvarma ashutoshvarma ashutoshvarma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaunxw @Dinonard @ashutoshvarma