Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Add dial timeout option #20

Merged
merged 3 commits into from
May 22, 2023
Merged

[minor] Add dial timeout option #20

merged 3 commits into from
May 22, 2023

Conversation

t4niwa
Copy link
Contributor

@t4niwa t4niwa commented May 12, 2023

Description

Add dial timeout option

Type of change

  • Bug fix
  • New feature
  • Refactoring (no functional changes, no api changes)
  • Non-code changes (update documentation, pipeline, etc.)

Flags

  • Breaks backward compatibility
  • Requires a documentation update
  • Has untestable code

Related issue/PR

Delete this section if there are no issues or pull requests that relate to this pull request.

  • Fixes #issue
  • Closes #PR

Checklist

  • Followed the guidelines in the CONTRIBUTING document
  • Added prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip] in the PR title if necessary
  • Tested and linted the code
  • Commented the code
  • Made corresponding changes to the documentation
  • Passed all pipeline checking

Checklist for maintainer

  • Use Squash and merge
  • Double-confirm the merge message has prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]
  • Delete the branch after merge

@t4niwa t4niwa force-pushed the add-dial-timeout-option branch 3 times, most recently from 4604fd5 to be55bca Compare May 16, 2023 07:31
Copy link
Contributor

@thgm3116 thgm3116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2つコメントを出しています。
ご確認をお願いいたします。

handler/handler_test.go Outdated Show resolved Hide resolved
handler/handler.go Show resolved Hide resolved
taniwa added 3 commits May 17, 2023 18:59
fix

Signed-off-by: taniwa <[email protected]>

add updateDialContext()

Signed-off-by: taniwa <[email protected]>
Signed-off-by: taniwa <[email protected]>
Copy link
Contributor

@thgm3116 thgm3116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t4niwa t4niwa changed the title [nightly] Add dial timeout option [minor] Add dial timeout option May 22, 2023
@thgm3116 thgm3116 merged commit 28d2c0a into master May 22, 2023
2 checks passed
@thgm3116 thgm3116 deleted the add-dial-timeout-option branch May 22, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants