Add metrics for principal cache memory usage #42
+335
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fum1h1to <75571344+fum1h1to@users.noreply.github.com>
Signed-off-by: fum1h1to <75571344+fum1h1to@users.noreply.github.com>
fum1h1to
force-pushed
the
feature/add-principal-cache-metrics
branch
from
1cf5e27
to
a10d2fa
Compare
Signed-off-by: fum1h1to <75571344+fum1h1to@users.noreply.github.com>
Signed-off-by: fum1h1to <75571344+fum1h1to@users.noreply.github.com>
Signed-off-by: fum1h1to <75571344+fum1h1to@users.noreply.github.com>
Signed-off-by: fum1h1to <75571344+fum1h1to@users.noreply.github.com>
Signed-off-by: fum1h1to <75571344+fum1h1to@users.noreply.github.com>
Signed-off-by: fum1h1to <75571344+fum1h1to@users.noreply.github.com>
Signed-off-by: fum1h1to <75571344+fum1h1to@users.noreply.github.com>
Signed-off-by: fum1h1to <75571344+fum1h1to@users.noreply.github.com>
y-myajima
reviewed
Sep 17, 2024
service/metrics.go
Outdated
|
|
||
| // Collect is implementation of prometheus.Collector.Collect | ||
| func (m *metrics) Collect(ch chan<- prometheus.Metric) { | ||
| // m.mutex.RLock() |
service/metrics.go
Outdated
| for _, opt := range opts { | ||
| opt(m) | ||
| } | ||
|
|
||
| err := prometheus.Register(m.httpOriginLatency) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "cannot register metrics") |
There was a problem hiding this comment.
なんのメトリクスの登録に失敗したかわかるようにしてください
service/metrics.go
Outdated
| err := prometheus.Register(m.httpOriginLatency) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "cannot register metrics") | ||
| } | ||
|
|
||
| err = prometheus.Register(m) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "cannot register metrics") |
Signed-off-by: fum1h1to <75571344+fum1h1to@users.noreply.github.com>
Signed-off-by: fum1h1to <75571344+fum1h1to@users.noreply.github.com>
Signed-off-by: fum1h1to <75571344+fum1h1to@users.noreply.github.com>
92aec89 で追加 |
Signed-off-by: fum1h1to <75571344+fum1h1to@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add memoryUsage for principal cache
Type of change
Flags
Related issue/PR
Delete this section if there are no issues or pull requests that relate to this pull request.
Checklist
[skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]in the PR title if necessaryChecklist for maintainer
Squash and merge[skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]