-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: allow calling SchemaType.cast()
without parent
and init
parameters
#14756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasezoey
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some slight suggestions
Co-authored-by: hasezoey <hasezoey@gmail.com>
@hasezoey please take a look at the new implementation, I added a test based on your comments, and also some more logic to allow passing |
hasezoey
approved these changes
Jul 24, 2024
This was referenced Aug 21, 2024
This was referenced Aug 21, 2024
Fix #14748
Re: #9076
Summary
The
doc
andinit
parameters tocast()
should be optional in TypeScript, we have plenty of tests that callSchemaType.prototype.cast()
with only 1 arg. Plus #9076 recommends usingSchema.Types.Subdocument.prototype.cast()
as an alternative for instantiating a subdocument without an associated parent document, which is the root cause of the issue in #14748.Examples