Revert Inline breaking change #12638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJul
force-pushed
the
fix/inline-breaking-change
branch
from
19c5da7
to
495e2bb
Compare
|
You can test this PR using the following package version. |
|
I wonder if this should have an additional comment or be added to #12276. Otherwise, it will probably be forgotten about and the API never switched back to AttachedProperty. Edit: I need to read... you have the comment. And #12276 is already referenced here in the comment so it should be seen in the future. |
maxkatz6
approved these changes
Aug 23, 2023
|
Opened an issue to track the API Compat problem: dotnet/sdk#34864 |
MrJul
added
the
backport-candidate-11.0.x
grokys
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12624 introduced a binary breaking change undetected by the API diff tool: the public field
Inline.TextDecorationsPropertyhas a different return type.Fixed by reverting the declaration to
StyledProperty, while keeping the new behavior.