Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build for Docker v 20.10.9 #48

Merged
merged 5 commits into from
Jun 22, 2023
Merged

Fix build for Docker v 20.10.9 #48

merged 5 commits into from
Jun 22, 2023

Conversation

madelen-at-work
Copy link
Contributor

@madelen-at-work madelen-at-work commented Jun 16, 2023 •
edited
Loading

Fixes issue with package not building when using Docker version 20.10.9 as base. Main issue was that the Debian Stretch repos for updates/security has moved to archive. Since Stretch has reached EOL there is also an issue with some packages no longer being authorized. Uses same fix as docker-acap PR#98

A second PR#49 will bump Docker version but I suggest we merge this first to have a buildable (at least for now) history.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@madelen-at-work
Testing fix from docker-acap
8423f70 
Change-Id: I3a13eb46f6a982828fca6e7d281c49500e63d68e
@madelen-at-work
fix
d7bf786 
Change-Id: I164f75309bf09eb8beb04eb59abf4e8f7ae1e78e
@madelen-at-work
cleanup
0b4ca54 
Change-Id: Ic78654fe77132a0138e628637bec4d8bc8952fe9
@madelen-at-work madelen-at-work changed the title Testing fix from docker-acap Fix build for Docker v 20.10.9 Jun 19, 2023
@madelen-at-work madelen-at-work marked this pull request as ready for review June 19, 2023 10:01
@madelen-at-work madelen-at-work requested a review from a team as a code owner June 19, 2023 10:01
@madelen-at-work madelen-at-work merged commit 74735d8 into main Jun 22, 2023
6 checks passed
@madelen-at-work madelen-at-work deleted the fix-build branch June 22, 2023 11:25
madelen-at-work added a commit that referenced this pull request Oct 24, 2023
@madelen-at-work
Merge branch 'heads/main' into versions-update
814e564 
* heads/main:
  Bump actions/checkout from 3 to 4 (#51)
  Remove hooks for DockerHub (#50)
  Fix build for Docker v 20.10.9 (#48)

Change-Id: I7d504c8a58e0513c6f581e808487821ea11c94ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jojju jojju jojju approved these changes

@kristinub kristinub Awaiting requested review from kristinub

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madelen-at-work @jojju