Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating sample code to use latest API versions #1829

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ut-karsh
Copy link
Contributor

Purpose

  • Only updated C# in previous PR. Updating other programming languages in this PR to Speech REST API version 3.1 and ConversationAnalysis API version 2022-10-01-preview.

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ x] Other... Please describe: Updating API versions, no functional changes.

Only updated C# in previous PR. Updating other programming languages in this PR to Speech REST API version to 3.1 and ConversationAnalysis API version to 2022-10-01-preview.
@ut-karsh
Copy link
Contributor Author

@trrwilson and @BrianMouncer for review.

CONVERSATION_ANALYSIS_QUERY = "?api-version=2022-05-15-preview";
CONVERSATION_SUMMARY_MODEL_VERSION = "2022-05-15-preview";
CONVERSATION_ANALYSIS_QUERY = "?api-version=2022-10-01-preview";
CONVERSATION_SUMMARY_MODEL_VERSION = "latest";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the point of using latest, when CONVERSATION_ANALYSIS_QUERY and SPEECH_TRANSCRIPTION_PATH are static.

e.g. when v3.2 comes out, these existing clients will start using the new model version, but the old path and query, is that what you want to happen, or will that just make this more likely to break in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was provided by the Language team. It is likely that the Conversation Summary model version is updated frequently even when the API path remains the same, which would be hard to keep track of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants