Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IngestionClient] Unit test coverage as part of the CI/CD pipeline #2515

Merged
merged 17 commits into from
Jul 30, 2024

Conversation

ross-p-smith
Copy link
Contributor

@ross-p-smith ross-p-smith commented Jul 22, 2024

Purpose

This PR is actually #2503 but with the comments fixed. Original work has been carried out by @komalg1

This adds Code Coverage report into the project so we can baseline the tests

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@ross-p-smith
Copy link
Contributor Author

@HenryvanderVegte this PR is using the GITHUB_TOKEN which will not work on a fork, as you cannot access that Token from a fork. I believe the theory is that this workflow when run under the repo context (not fork) will have access to the token and will be able to write the Test Coverage as a comment in the PR

@HenryvanderVegte
Copy link
Contributor

/azurepipelines run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@zhouwangzw
Copy link
Contributor

/azurepipelines run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@yulin-li
Copy link
Contributor

@ross-p-smith @HenryvanderVegte @zhouwangzw The azure pipeline build from a forked repo is disabled now for some security reasons, we are contact to ado org admin to see if we can enable it again.

@yulin-li
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HenryvanderVegte
Copy link
Contributor

@ross-p-smith @HenryvanderVegte @zhouwangzw The azure pipeline build from a forked repo is disabled now for some security reasons, we are contact to ado org admin to see if we can enable it again.

thanks a lot @yulin-li !

@HenryvanderVegte HenryvanderVegte merged commit c808bef into Azure-Samples:master Jul 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants