Refactor key vault types #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalarme
requested changes
Aug 26, 2024
Scenarios/Secure-Baseline/bicepWithAVM/03-Supporting-Services/modules/key-vault/types.bicep
Outdated
Show resolved
Hide resolved
pmalarme
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
Scenarios/Secure-Baseline/bicepWithAVMfiles, focusing on enhancing the key vault and secret management. The most important changes include importing new types, adding new parameters, and updating existing types to support more detailed configurations.Enhancements to Key Vault and Secret Management:
Scenarios/Secure-Baseline/bicepWithAVM/03-Supporting-Services/main.bicep: AddedsecretTypeto the imports and introduced a new parameter for secrets to be created in the key vault. [1] [2]Scenarios/Secure-Baseline/bicepWithAVM/03-Supporting-Services/main.bicepparam: Added a new parametersecretsto support secret configurations.Updates to Key Vault Types:
Scenarios/Secure-Baseline/bicepWithAVM/03-Supporting-Services/modules/key-vault/types.bicep: Removed redundant typescurveNameTypeandktyType, and directly defined their values in thekeyType. [1] [2]Scenarios/Secure-Baseline/bicepWithAVM/03-Supporting-Services/modules/key-vault/types.bicep: Added a newsecretTypeto define the properties of secrets, including attributes, content type, tags, and role assignments.