[ARO-5445] DNS checker logging custom DNS server as an error #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandmkunkel
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
dofinn and
tiguelu
as code owners
tiguelu
approved these changes
Mar 12, 2024
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kimorris27
approved these changes
Mar 12, 2024
mociarain
approved these changes
Mar 12, 2024
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tiguelu
deleted the
ARO-5445-DNS-checker-logging-custom-DNS-server-as-an-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-5445
What this PR does / why we need it:
Customer reported ARO operator errors in the logs when custom DNS servers are configured in forward plugin:
https://portal.microsofticm.com/imp/v3/incidents/incident/469705806/summary
This is a supported setup as per our docs and should not be logged as an error.
The DNS checks had been setup initially to be included as cluster conditions for SRE awareness (this did not log the status conditions as errors):
https://github.com/Azure/ARO-RP/blob/3e69b7e742af5aeee471a8d781d518c72fd235dd/pkg/operator/controllers/checker/clusterdns.go
A refactoring was done in this commit. Since then, when the status now needs to be updated, the new logic is returning an Error to the Reconciler, which in turn always returns the error to K8s controller-runtime, which is where it is being logged as an error.